Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Forward and Reverse in MachineDirection enumeration #493

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Sep 26, 2024

Describe your changes

Fixed incorrect values interpreted and sent for SPNs 1861, 4309, 1864, and 4312.

Fixes #491

How has this been tested?

Updated unit tests to cover this change, 100% covered.

Fixed incorrect values interpreted and sent for SPNs 1861, 4309, 1864, and 4312.
@ad3154 ad3154 added bug Something isn't working iso: application messages Related to the ISO-11783:7 standard labels Sep 26, 2024
@ad3154 ad3154 requested a review from GwnDaan September 26, 2024 05:26
@ad3154 ad3154 self-assigned this Sep 26, 2024
Copy link

@ad3154 ad3154 merged commit 6155acd into main Sep 27, 2024
10 checks passed
@ad3154 ad3154 deleted the adrian/mss-enum-fix branch September 27, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iso: application messages Related to the ISO-11783:7 standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Machine Direction wrong enum vaues
2 participants