Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC]: Extending DDOP with binary object pool #524

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

GwnDaan
Copy link
Member

@GwnDaan GwnDaan commented Jan 5, 2025

Describe your changes

This PR allows you to extend an already existing populated DDOP object with more binary data. This is especially useful if the DDOP is transferred in multiple trips to the TC.

How has this been tested?

  • Test with physical implements to see if it allows extending pools, while keeping original functionality

@GwnDaan GwnDaan added enhancement New feature or request iso: task controller Related to the ISO-11783:10 standard labels Jan 5, 2025
@GwnDaan GwnDaan self-assigned this Jan 5, 2025
@GwnDaan GwnDaan marked this pull request as ready for review January 8, 2025 11:30
@GwnDaan GwnDaan requested review from ad3154 and Copilot January 8, 2025 11:30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • isobus/include/isobus/isobus/isobus_device_descriptor_object_pool.hpp: Language not supported
  • isobus/src/isobus_device_descriptor_object_pool.cpp: Language not supported
@GwnDaan GwnDaan merged commit 4ad8020 into main Jan 9, 2025
11 checks passed
@GwnDaan GwnDaan deleted the daan/extend-ddop branch January 9, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iso: task controller Related to the ISO-11783:10 standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants