Remove duplicated code

[martonmiklos]

Describe your changes

Removed duplicate codes to support Open-Agriculture/AgIsoVirtualTerminal#55

How has this been tested?

Loaded Kverneland implements in AgIsoVT

[martonmiklos]

@GwnDaan I do not have too much idea why the doxygen pipeline is failing, do you have any suggestions?

[GwnDaan]

@martonmiklos This my way of finding what's wrong :)

[martonmiklos]

@martonmiklos This my way of finding what's wrong :)

Dauh, Ctrl+F and dynamic page load are my new enemy :D

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)

• isobus/src/isobus_virtual_terminal_objects.cpp: Language not supported

[GwnDaan]

Good job! I like how you were able to reduce the duplication with a few simple base classes

[GwnDaan]

@martonmiklos one nitpick, can you rephrase your commit message to be a little more descriptive?

e.g. refactor(vt-objects)!: replace duplicated functions with base classes

This way, someone can scrolls through to commits to get an idea of the changes made, and whether or not they are breaking to them. https://www.conventionalcommits.org/en/v1.0.0/ is pretty nice if you ask me

[GwnDaan]

Also @ad3154, I would like to hear your thoughts on this and whether your initial concern still applies

One reason they are not combined right now is because they inherit from isobus::OutputNumber vs isobus::InputNumber for example, which allows for convenient use of isobus::VTObject::get_object_type and other things like that. In theory I'm not opposed to combining them but there will probably be other things that need to get re-done to make that happen, or at the very least you may need to override some virtual functions in creative ways

Originally posted by @ad3154 in Open-Agriculture/AgIsoVirtualTerminal#55 (comment)

[martonmiklos]

@martonmiklos one nitpick, can you rephrase your commit message to be a little more descriptive?

e.g. refactor(vt-objects)!: replace duplicated functions with base classes

This way, someone can scrolls through to commits to get an idea of the changes made, and whether or not they are breaking to them. https://www.conventionalcommits.org/en/v1.0.0/ is pretty nice if you ask me

I have fixed the commit message, I will try to keep myself to the mentioned conventions in the future.

[ad3154]

Also @ad3154, I would like to hear your thoughts on this and whether your initial concern still applies

I think this does a good job at reducing duplication, and it leaves get_object_type alone which is nice, so I'm happy.