-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete object option encapsulation #38
Complete object option encapsulation #38
Conversation
Hey @JannesBrands, the test case |
It's a todo. For that reason it's failing. The actual test is working.
I wanted to implement that inside the other PR that you merged last week. So now I'm completing in more little steps the things that were missing. The unit test of "read working set" does not belong directly to this PR. I'll do another later to complete the testing. |
So I could fix that inside this PR, but since this PR is about something else I would like to keep it inside a new PR. @GwnDaan let me know your opinion, if not, I'll fix it here. |
That PR has been "unmerged", so basically this PR is that one + any additions you made since then. I don't mind a failing test for now since the target branch is not develop |
Ahhhhhh, my bad. I didn't understand that point or better said: I forgot what actually happened at the end with the PR and merge haha. Let me change the description and title later. |
Merging this now to allow us to faster iterate on it in main 😄 |
78f6b8a
into
Open-Agriculture:tjd/object-pool
Here my completion of the encapsulation of each object option byte into an specific struct. Fast reviews are welcome to merge this fast.