-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include licenseInfo for all the generated java code files #19273
Conversation
fae76d5
to
ceae687
Compare
https://github.com/OpenAPITools/openapi-generator/actions/runs/10174522356/job/28316252859?pr=19273 please update the samples when you've time |
thanks, updated the sample. |
https://github.com/OpenAPITools/openapi-generator/actions/runs/10238086384/job/28345688715?pr=19273 fixed in the master so please ignore it for the time being |
f4f7b55
to
13871f1
Compare
thanks, rebased the code and tried to re-generate |
thanks for the PR. let's give it a try |
### What changes were proposed in this pull request? This pr is a followup for #2641 In above PR, I upgrade the version to 7.7.0, and there were two generated java files not with apache licenses. And then I raised a PR in OpenAPITools/openapi-generator#19273 to followup it, and it is released in https://github.com/OpenAPITools/openapi-generator/releases/tag/v7.8.0. ### Why are the changes needed? Upgrade to the latest openapi-generator version to resolve the unlicensed java files. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing GA. Closes #2695 from turboFei/openapi_upgrade. Authored-by: Wang, Fei <[email protected]> Signed-off-by: mingji <[email protected]>
### What changes were proposed in this pull request? This pr is a followup for apache#2641 In above PR, I upgrade the version to 7.7.0, and there were two generated java files not with apache licenses. And then I raised a PR in OpenAPITools/openapi-generator#19273 to followup it, and it is released in https://github.com/OpenAPITools/openapi-generator/releases/tag/v7.8.0. ### Why are the changes needed? Upgrade to the latest openapi-generator version to resolve the unlicensed java files. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing GA. Closes apache#2695 from turboFei/openapi_upgrade. Authored-by: Wang, Fei <[email protected]> Signed-off-by: mingji <[email protected]>
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)