[Kotlin] Add a new additional property to configure Jackson's failOnUnknownProperties

[fistons]

This PR intents to fix #19408 and to have the same default behavior as the Java clients' i.e. being able to configure the Jackson's ObjectMapper FAIL_ON_UNKNOWN_PROPERTIES.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh ./bin/configs/*.yaml
  ./bin/utils/export_docs_generators.sh
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[wing328]

@fistons thanks for the PR

let us know if you need help to complete this PR

cc
@dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

[fistons]

You are welcome! I still need to work on it, I will let you know if I need help

[fistons]

Should be good now!

[akdoan1]

does this allow setting FAIL_ON_UNKNOWN_PROPERTIES to true?

[fistons]

As far as I understand the generator, FAIL_ON_UNKNOWN_PROPERTIES will be true if and only if the we specify the failOnUnknownProperties option to true.

Am I right?

[akdoan1]

I'm new to the repository, so I may be wrong here, but reading these lines, it looks as though we only update the property value (and to false) if the property isn't included by the user configuration.

The other properties are in this format:

        if (additionalProperties.containsKey(KEY)) {
            setKey(additionalProperties.get(KEY).toString());
        }

such as:

        if (additionalProperties.containsKey(REQUEST_DATE_CONVERTER)) {
            setRequestDateConverter(additionalProperties.get(REQUEST_DATE_CONVERTER).toString());
        }

Which reads as though - if provided, we will override the value based on the provided value. I'm sure a unit test will make this clear, though.

[fistons]

Indeed, you are right, thanks!

I refactored this part and added a unit test for this.

[akdoan1]

Should the changes in this file have a new unit test in KotlinClientCodegenModelTest?

[fistons]

Sure, I will add one

[fistons]

Done!

[akdoan1]

@wing328 can we get additional reviews on this? When is the cutoff to include this change in the 7.9.0 release on 2024-09-23?

[wing328]

thanks for the PR, which has been merged