Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Respect User Supplied Header Params #20042

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

ckoegel
Copy link
Contributor

@ckoegel ckoegel commented Nov 6, 2024

Work done in #20032 for the Java okhttp-gson generator only.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@macjohnny
Copy link
Member

cc Java - @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@ckoegel
Copy link
Contributor Author

ckoegel commented Nov 6, 2024

circleci node0 is currently failing with the error: Internal error in Develocity Maven extension: Failed to capture test events
Do these just need to be re-run or could this be caused by something in my PR?

@macjohnny
Copy link
Member

you can try merging to most recent master

@macjohnny
Copy link
Member

@ckoegel can you merge the most recent master? #20062 fixes the typescript test that fails

@wing328 wing328 added this to the 7.10.0 milestone Nov 9, 2024
@wing328 wing328 merged commit 5702751 into OpenAPITools:master Nov 9, 2024
96 checks passed
@ckoegel ckoegel deleted the ckoegel-content-type-java branch November 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants