Skip to content

Commit

Permalink
Reverting experimental c++17 mode (mac build failures with Catch code…
Browse files Browse the repository at this point in the history
…). Disabling GitHub windows builders for now - since they are using bleeding edge opencv and protobuf, which is incompatible with my old Cmake and old Opencv installs.
  • Loading branch information
jonoomph committed Feb 11, 2024
1 parent c7620c9 commit 4117177
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
sys:
- { os: ubuntu-20.04, shell: bash }
- { os: ubuntu-22.04, shell: bash }
- { os: windows-2022, shell: 'msys2 {0}' }
#- { os: windows-2022, shell: 'msys2 {0}' } Disabled until we upgrade to C++17 and find_package(Protobuf CONFIG REQUIRED)
compiler:
- { cc: gcc, cxx: g++ }
- { cc: clang, cxx: clang++ }
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ if ((${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU") AND
endif()

#### Set C++ standard level
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

Expand Down

0 comments on commit 4117177

Please sign in to comment.