fix: Rack attack can't be completely disabled #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #449 +/- ##
===========================================
+ Coverage 77.59% 77.68% +0.08%
===========================================
Files 61 61
Lines 1616 1627 +11
===========================================
+ Hits 1254 1264 +10
- Misses 362 363 +1
☔ View full report in Codecov by Sentry. |
|
Must be checked last time using Docker environment, I'm on it |
Quentinchampenois
requested review from
moustachu,
a team and
AyakorK
and removed request for
a team
moustachu
approved these changes
Nov 6, 2023
1 task
moustachu
pushed a commit
that referenced
this pull request
Mar 6, 2024
* fix: backport from rake attack from cd44 * lint: Fix rubocop offenses * fix: System confirmation specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 Description
Please describe your pull request.
Add configuration to disable completely rack attack using env var
ENABLE_RACK_ATTACK=0Now initializer logs the current Rack Attack configuration on startup
Related to
#444
Tasks