Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade wicked_pdf #458

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Nov 22, 2023

🎩 Description

We downgrade wicked pdf to make sure that it works correctly

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as admin
  • Access Backoffice
  • Go to initiatives
  • Select one published and add your signature
  • Export the signatures of this one
  • Check if everything works correctly

Tasks

  • Downgrade wicked_pdf

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d0d01e) 77.68% compared to head (91de871) 77.68%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #458   +/-   ##
========================================
  Coverage    77.68%   77.68%           
========================================
  Files           61       61           
  Lines         1627     1627           
========================================
  Hits          1264     1264           
  Misses         363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyakorK AyakorK marked this pull request as ready for review November 23, 2023 13:56
@AyakorK AyakorK requested review from Quentinchampenois, luciegrau and a team November 23, 2023 13:57
@Quentinchampenois
Copy link
Contributor

Is there a test for testing the signature export

@luciegrau luciegrau merged commit 3c9e7ee into develop Nov 23, 2023
16 checks passed
@luciegrau luciegrau deleted the fix/exports_initiatives_signatures_0.27 branch November 23, 2023 15:21
moustachu pushed a commit that referenced this pull request Mar 6, 2024
* fix: downgrade wicked_pdf

* fix: Add the requirement of the wicked_pdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants