Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the commit to fix notifications not sending on dcd-app #463

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Nov 29, 2023

🎩 Description

We had an issue with notifications not sending onto the 0.27 apps because a change we made in the module term customizer. So as we fixed it on the branch we needed to update the last commit.

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as user
  • Go follow a process
  • Log as an admin
  • Comment the process that has been followed
  • Log as the previous user
  • Check if you received the notification

Tasks

  • Change Revision of Term Custo

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8965d5e) 77.68% compared to head (4ace7e0) 77.68%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #463   +/-   ##
========================================
  Coverage    77.68%   77.68%           
========================================
  Files           61       61           
  Lines         1627     1627           
========================================
  Hits          1264     1264           
  Misses         363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyakorK AyakorK marked this pull request as ready for review November 29, 2023 14:40
@AyakorK AyakorK requested review from luciegrau, a team and Quentinchampenois and removed request for a team November 29, 2023 14:40
@luciegrau luciegrau merged commit 637cd47 into develop Nov 29, 2023
16 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/notifications_not_sending branch November 29, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants