Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: Answer Initiatives Notifications #464

Merged
merged 7 commits into from
Dec 5, 2023
Merged

backport: Answer Initiatives Notifications #464

merged 7 commits into from
Dec 5, 2023

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Nov 29, 2023

🎩 Description

This PR backports the notifications when an initiative is answered

📌 Related Issues

Link your PR to an issue

Testing

Example:
Describe the best way to test or validate your PR.

  • Follow a published initiative
  • Access Backoffice
  • Go to initiatives and answer the previously followed initiative
  • Check your notifications
  • Check your emails

Tasks

  • Add specs
  • Override Initiatives Update Behavior
  • Override Icon Display Behavior

@AyakorK AyakorK marked this pull request as ready for review November 29, 2023 17:02
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (637cd47) 77.68% compared to head (0cc4b64) 78.23%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #464      +/-   ##
===========================================
+ Coverage    77.68%   78.23%   +0.54%     
===========================================
  Files           61       64       +3     
  Lines         1627     1668      +41     
===========================================
+ Hits          1264     1305      +41     
  Misses         363      363

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyakorK AyakorK marked this pull request as draft November 29, 2023 17:10
@AyakorK AyakorK marked this pull request as ready for review November 29, 2023 17:21
@AyakorK AyakorK requested review from Quentinchampenois, luciegrau and a team November 29, 2023 17:21
luciegrau
luciegrau approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Make sure you have configured real-time notifications in your user account so that you can test the PR

Quentinchampenois
Quentinchampenois approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks

@Quentinchampenois Quentinchampenois merged commit 2e4c42c into develop Dec 5, 2023
16 checks passed
@Quentinchampenois Quentinchampenois deleted the backport/answer_initiative_notification branch December 5, 2023 15:59
moustachu pushed a commit that referenced this pull request Mar 6, 2024
@AyakorK @moustachu
backport: Answer Initiatives Notifications (#464)
658e598 
* backport: Add initiative answers notifications

* lint: Rubocop fixes

* fix: Add some tests and fix i18n

* fix: Delete factory_bot_spec as we didn't do any customization of the factories

* fix: Add new tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luciegrau luciegrau luciegrau approved these changes

@Quentinchampenois Quentinchampenois Quentinchampenois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyakorK @Quentinchampenois @luciegrau