Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Active Storage path style for scaleway object storage #466

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

moustachu
Copy link
Member

Force the object storage URL to be like :
https://<endpoint>/<bucket>/...
instead of
https://<bucket>.<endpoint>/...

@moustachu moustachu requested review from Quentinchampenois and a team December 14, 2023 09:17
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3357f53) 89.37% compared to head (eb996ea) 89.37%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #466   +/-   ##
========================================
  Coverage    89.37%   89.37%           
========================================
  Files           64       64           
  Lines         1581     1581           
========================================
  Hits          1413     1413           
  Misses         168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois merged commit a489a50 into develop Dec 18, 2023
16 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/scw-active-storage-path-style branch December 18, 2023 08:38
moustachu added a commit to OpenSourcePolitics/decidim-cdc that referenced this pull request Aug 22, 2024
moustachu added a commit to OpenSourcePolitics/decidim-cdc that referenced this pull request Aug 22, 2024
moustachu added a commit to OpenSourcePolitics/decidim-cdc that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants