Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Budgets Project filters Ambiguous ID #478

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Quentinchampenois
Copy link
Contributor

🎩 Description

Please describe your pull request.

When filtering, it causes a 500 error

 ActionView::Template::Error (PG::AmbiguousColumn: ERROR:  column reference "id" is ambiguous
oncat(',', id::text, ',') in ',,')...
           ^
      5: </div>
      6: 
      7: <div class="budget-list">
      8:   <% projects.each do |project| %>
      9:     <%= render partial: "project", locals: { project: project } %>
     10:     <%= render partial: "project_modal", locals: { project: project } %>
     11:   <% end %>

📌 Related Issues

Link your PR to an issue

Fixes #476

Testing

Describe the best way to test or validate your PR.

With a running Docker env you can setup this application locally by running make run and access it at : https://localhost:3000

Example:

  • Go to budgets
  • Try to filter
  • You should not have 500 error

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4ae434) 89.34% compared to head (4a4119c) 89.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #478      +/-   ##
===========================================
+ Coverage    89.34%   89.39%   +0.05%     
===========================================
  Files           65       66       +1     
  Lines         1595     1603       +8     
===========================================
+ Hits          1425     1433       +8     
  Misses         170      170              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois marked this pull request as ready for review January 26, 2024 11:15
@Quentinchampenois Quentinchampenois requested review from luciegrau and a team January 26, 2024 11:15
@luciegrau luciegrau enabled auto-merge (squash) January 31, 2024 13:42
@luciegrau luciegrau disabled auto-merge January 31, 2024 13:43
@Quentinchampenois Quentinchampenois merged commit a5b9852 into develop Jan 31, 2024
16 checks passed
@Quentinchampenois Quentinchampenois deleted the backport/decidim_pr_11474 branch January 31, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ambiguous id column on projects query
2 participants