Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Fix proposal index filters that were not working (#595) #598

Merged
merged 1 commit into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ source "https://rubygems.org"

DECIDIM_VERSION = "0.27"
DECIDIM_BRANCH = "release/#{DECIDIM_VERSION}-stable".freeze
DECIDIM_ANONYMOUS_PROPOSALS_VERSION = { git: "https://github.com/PopulateTools/decidim-module-anonymous_proposals", branch: "anonymous_proposals_for_registered_users" }.freeze
DECIDIM_ANONYMOUS_PROPOSALS_VERSION = { git: "https://github.com/OpenSourcePolitics/decidim-module-anonymous_proposals",
branch: "feat/disable_override_from_index_proposals" }.freeze

ruby RUBY_VERSION

Expand Down
18 changes: 9 additions & 9 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
GIT
remote: https://github.com/OpenSourcePolitics/decidim-module-anonymous_proposals
revision: ea7c828c82fabb1c35e161095082f15ba63b6eaf
branch: feat/disable_override_from_index_proposals
specs:
decidim-anonymous_proposals (0.27.0)
decidim-core (>= 0.27.0)
deface (~> 1.5)

GIT
remote: https://github.com/OpenSourcePolitics/decidim-module-extended_socio_demographic_authorization_handler.git
revision: adec5e66cd07b5e5fdce5562453a7e8d6de88013
Expand Down Expand Up @@ -112,15 +121,6 @@ GIT
omniauth (~> 2.0)
omniauth-oauth2 (>= 1.7.2, < 2.0)

GIT
remote: https://github.com/PopulateTools/decidim-module-anonymous_proposals
revision: b44a938500716dbfd99e8615769045701137c82e
branch: anonymous_proposals_for_registered_users
specs:
decidim-anonymous_proposals (0.27.0)
decidim-core (>= 0.27.0)
deface (~> 1.5)

GIT
remote: https://github.com/alecslupu-pfa/decidim-budget_category_voting.git
revision: e059d392d6468a0fff556a458589685a047032d6
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,17 @@
<% end %>
<% end %>
<%= render partial: "voting_rules" %>

<%= render partial: "decidim/anonymous_proposals/shared/anonymous_proposals_announcement" %>
<div class="row columns">
<div class="title-action">
<h2 id="proposals-count" class="title-action__title section-heading">
<%= render partial: "count" %>
</h2>
<% if current_settings.creation_enabled && current_component.participatory_space.can_participate?(current_user) %>
<%= action_authorized_link_to :create, new_proposal_path, class: "title-action__action button small", data: { "redirect_url" => new_proposal_path } do %>

<%= link_to new_proposal_path, class: "title-action__action button small", data: { "redirect_url" => new_proposal_path } do %>

<%= t(".new_proposal") %>
<%= icon "plus", role: "img", "aria-hidden": true %>
<% end %>
Expand Down
10 changes: 10 additions & 0 deletions app/views/decidim/proposals/proposals/index.js.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
var $proposals = $('#proposals');
var $proposalsCount = $('#proposals-count');
var $orderFilterInput = $('.order_filter');

$proposals.html('<%= j(render partial: "proposals").strip.html_safe %>');
$proposalsCount.html('<%= j(render partial: "count").strip.html_safe %>');
$orderFilterInput.val('<%= order %>');

var $dropdownMenu = $('.dropdown.menu', $proposals);
$dropdownMenu.foundation();
9 changes: 5 additions & 4 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,11 @@ en:
new:
add_file: Add file
edit_file: Edit file
index:
collaborative_drafts_list: Collaborative drafts list
new_proposal: New proposal
view_proposal: View proposal
proposals:
index:
collaborative_drafts_list: Collaborative drafts list
new_proposal: New proposal
view_proposal: View proposal
update:
error: There was a problem saving the idea.
success: Idea successfully updated.
Expand Down
9 changes: 5 additions & 4 deletions config/locales/fr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,11 @@ fr:
new:
add_file: Ajouter le fichier
edit_file: Editer le fichier
index:
collaborative_drafts_list: Accéder aux brouillons collaboratifs
new_proposal: Nouvelle proposition
view_proposal: Voir la proposition
proposals:
index:
collaborative_drafts_list: Accéder aux brouillons collaboratifs
new_proposal: Nouvelle proposition
view_proposal: Voir la proposition
update:
error: Il y a eu une erreur lors de la mise à jour de la proposition.
success: Proposition mise à jour avec succès.
Expand Down
Loading