fix: disable Rack Attack when ENABLE_RACK_ATTACK=0 (#37) (#38)

* fix: disable Rack Attack when ENABLE_RACK_ATTACK=0 * update chromedirver version to 117.0.5938.132
OpenSourcePolitics · Oct 4, 2023 · 9645fd2 · 9645fd2
1 parent bf8a998
commit 9645fd2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/ci_cd.yml b/.github/workflows/ci_cd.yml
@@ -91,7 +91,7 @@ jobs:
       # TODO: Use latest version
       - uses: nanasess/setup-chromedriver@v2
         with:
-          chromedriver-version: "114.0.5735.90"
+          chromedriver-version: "117.0.5938.132"
       - run:  bundle exec rake "test:run[exclude, spec/system/**/*_spec.rb, ${{ matrix.slice }}]"
         name: RSpec
       - run: ./.github/upload_coverage.sh decidim-app $GITHUB_EVENT_PATH
@@ -159,7 +159,7 @@ jobs:
       # TODO: Use latest version
       - uses: nanasess/setup-chromedriver@v2
         with:
-          chromedriver-version: "114.0.5735.90"
+          chromedriver-version: "117.0.5938.132"
       - run:  bundle exec rake "test:run[include, spec/system/**/*_spec.rb, ${{ matrix.slice }}]"
         name: RSpec
       - run: ./.github/upload_coverage.sh decidim-app $GITHUB_EVENT_PATH

diff --git a/config/initializers/rack_attack.rb b/config/initializers/rack_attack.rb
@@ -6,4 +6,8 @@
 
 # Enabled by default in production
 # Can be deactivated with 'ENABLE_RACK_ATTACK=0'
-DecidimApp::RackAttack.apply_configuration if DecidimApp::RackAttack.rack_enabled?
+if DecidimApp::RackAttack.rack_enabled?
+  DecidimApp::RackAttack.apply_configuration
+else
+  Rack::Attack.enabled = false
+end