Skip to content

Commit

Permalink
Release (#20)
Browse files Browse the repository at this point in the history
* Fix rubocop

* Improve installation instructions (#16)

* Fix compat range (#17)

* Fix compat range

* Fix offenses

* Fix lint

* Fix tests

* Fix/no email (#18)

* Fix rubocop

* Don't query deleted users

* Don't query empty email users

* Bump gem to prepare release
  • Loading branch information
armandfardeau authored Mar 29, 2023
1 parent c2f650c commit 92c56db
Show file tree
Hide file tree
Showing 18 changed files with 198 additions and 179 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci_cleaner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ env:
CODECOV: "true"
RUBY_VERSION: 3.1.1
NODE_VERSION: 16.9.1
WEBPACKER_RUNTIME_COMPILE: "false"
RAILS_ENV: test

jobs:
lint:
Expand Down Expand Up @@ -91,7 +93,7 @@ jobs:
path: ./spec/decidim_dummy_app/tmp/screenshots
if-no-files-found: ignore
release:
if: "github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main'"
if: "github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release' )"
needs: [tests, lint]
runs-on: ubuntu-latest
steps:
Expand Down
6 changes: 5 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ inherit_from:
- .rubocop_rails.yml

AllCops:
TargetRubyVersion: 2.7.5
TargetRubyVersion: 3.1
Include:
- "**/*.rb"
- "**/*.rake"
Expand All @@ -16,3 +16,7 @@ AllCops:
- "vendor/**/*"
- "spec/decidim_dummy_app/**/*"
- "development_app/**/*"

RSpec/DescribeClass:
Exclude:
- spec/system/*
7 changes: 1 addition & 6 deletions .rubocop_ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@ AllCops:
# Otherwise we fallback to the oldest officially supported Ruby version (2.0).
TargetRubyVersion: 2.7

RSpec:
Patterns:
- "(?:^|/)spec/"
- "(?:^|/)test/"

# Indent private/protected/public as deep as method definitions
Layout/AccessModifierIndentation:
EnforcedStyle: indent
Expand Down Expand Up @@ -257,7 +252,7 @@ Style/BlockDelimiters:
- let!
- subject
- watch
IgnoredMethods:
AllowedMethods:
# Methods that can be either procedural or functional and cannot be
# categorised from their usage alone, e.g.
#
Expand Down
Loading

0 comments on commit 92c56db

Please sign in to comment.