Skip to content

Commit

Permalink
refactor: use translation key for aria-label in response to review fe…
Browse files Browse the repository at this point in the history
…edback
  • Loading branch information
BarbaraOliveira13 committed Dec 18, 2024
1 parent 601a7c0 commit 8f00d45
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions decidim-core/app/views/decidim/pages/_tabbed.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
</header>

<div class="vertical-tabs">
<nav role="navigation" aria-label="<%= i18n.t(".navigation.aria_label", title: translated_attribute(page.title)) %>">
<button id="dropdown-trigger-pages" data-component="dropdown" data-target="dropdown-menu-pages" data-open-md="true" data-auto-close="true">
<nav role="navigation" aria-label="<%= I18n.t("layouts.decidim.navigation.aria_label", title: translated_attribute(page.title)) %>">
<button id="dropdown-trigger-pages" data-component="dropdown" data-target="dropdown-menu-pages" data-open-md="true" data-auto-close="true">
<span>
<%= translated_attribute(page.title) %>
</span>
Expand Down
2 changes: 2 additions & 0 deletions decidim-core/config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2123,6 +2123,8 @@ en:
expire_time_html: Your session will expire in <b><span class="minutes">%{minutes}</span> minutes</b>.
language_chooser:
choose_language: Choose language
navigation:
aria_label: Navigation menu - %{title}
notifications_dashboard:
mark_all_as_read: Mark all as read
mark_as_read: Mark as read
Expand Down

0 comments on commit 8f00d45

Please sign in to comment.