Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add task to delete users follow #1227

Closed
wants to merge 3 commits into from

Conversation

Stef-Rousset
Copy link

@Stef-Rousset Stef-Rousset commented Jun 18, 2024

🎩 What? Why?

Add a rake task to delete existing unwanted follows of ex-private users from non transparent private assemblies or private processes

Testing

  1. As an admin, go to an existing assembly with meetings and update assembly to be private and non-transparent (or create one)
  2. In rails console, add a follow for the assembly and one for a child meeting from a user that is not a private user
    ex: Decidim::Follow.create!(decidim_user_id: non_private_user_id, decidim_followable_type: "Decidim::Meetings::Meeting", decidim_followable_id: meeting_from_private_assembly_id)
  3. In terminal, moove to development_app and run bundle exec rake decidim:upgrade:fix_deleted_private_follows
  4. See that follows added are deleted

♥️ Thank you!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@Stef-Rousset Stef-Rousset marked this pull request as ready for review June 18, 2024 11:14
@moustachu
Copy link
Member

Not needed anymore.
Fixes are on #1229

@moustachu moustachu closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants