Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ERC20FlashMint extension #407

Merged
merged 181 commits into from
Jan 7, 2025
Merged

feat: add ERC20FlashMint extension #407

merged 181 commits into from
Jan 7, 2025

Conversation

Ifechukwudaniel
Copy link
Contributor

@Ifechukwudaniel Ifechukwudaniel commented Nov 14, 2024 •
edited by 0xNeshi
Loading

NOTE: It is impossible to write any unit tests until it is possible to mock contract::address() in tests (see OpenZeppelin/stylus-test-helpers#5).

Resolves #355

PR Checklist

  • Tests
  • Documentation
  • Changelog

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit a7c0160
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67357c1f782e3e00081ecd3f

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit c2495db
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/677d6b16ccfb650008aea50d

@Ifechukwudaniel
Copy link
Contributor Author

This is my initial draft

0xNeshi
0xNeshi reviewed Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ifechukwudaniel!
Thanks for the contribution!

The PR overall looks good, let's polish it a bit

contracts/src/flashloan/borrower.rs Outdated Show resolved Hide resolved
contracts/src/flashloan/borrower.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flashmint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flashmint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flashmint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flashmint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flashmint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flashmint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flashmint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flashmint.rs Outdated Show resolved Hide resolved
Ifechukwudaniel and others added 18 commits November 14, 2024 12:08
@Ifechukwudaniel
chore : cargo format
47053bc
@Ifechukwudaniel @0xNeshi
Update contracts/src/token/erc20/extensions/flashmint.rs
6ea75eb 
Co-authored-by: Nenad <[email protected]>
@Ifechukwudaniel @0xNeshi
Update contracts/src/token/erc20/extensions/flashmint.rs
53ee21a 
Co-authored-by: Nenad <[email protected]>
@Ifechukwudaniel
chore: added docs for IERC3156FlashBorrower
3bd25cf 
chore: fixed tab
@Ifechukwudaniel
chore: docs
b9cce5d
@Ifechukwudaniel
Merge branch 'main' into erc20flashMint
03f6f38
@Ifechukwudaniel
Create erc20-flashloan.adoc
6aa5b6d
@Ifechukwudaniel
Merge pull request #1 from Ifechukwudaniel/patch-1
ebee8d5 
Create erc20-flashloan.adoc
@Ifechukwudaniel
chore: removed flashlaon and smaller changes
55672f6
@Ifechukwudaniel
chore: cargo format
626ae03
@Ifechukwudaniel
chore: abi and constructor
f8cdcf2
@Ifechukwudaniel
chore: flashloan example setup
85e62b1
@Ifechukwudaniel
chore: changed erc20FlashMint to erc20FlashMint
5feeb90
@Ifechukwudaniel
chore: erc20flashmint example
47aad90
@Ifechukwudaniel
chore: mock, abi and initial e2e test
99a8089
@Ifechukwudaniel
chore: created Erc3156FlashBorrowerMock
1b20ea6
@Ifechukwudaniel
chore: minor changes
4d08485
@Ifechukwudaniel
chore: cargo fmt fix
c3271bf 
chore: fixes
@Ifechukwudaniel
Copy link
Contributor Author

@0xNeshi what do you think about the new implementation for the extension

@0xNeshi 0xNeshi requested review from bidzyyys and 0xNeshi December 30, 2024 10:33
bidzyyys
bidzyyys reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to merge.

contracts/src/token/erc20/utils/safe_erc20.rs Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20-flash-mint.adoc Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flash_mint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flash_mint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flash_mint.rs Show resolved Hide resolved
contracts/src/token/erc20/extensions/flash_mint.rs Show resolved Hide resolved
contracts/src/token/erc20/extensions/flash_mint.rs Show resolved Hide resolved
contracts/src/token/erc20/extensions/flash_mint.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/flash_mint.rs Show resolved Hide resolved
examples/erc20-flash-mint/tests/mock/borrower.rs Outdated Show resolved Hide resolved
bidzyyys
bidzyyys reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not include benchmarks as they do not cover everything. I suggest removing this part at all, wdyt @qalisander?

@bidzyyys bidzyyys self-requested a review January 3, 2025 12:16
bidzyyys
bidzyyys reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

contracts/src/utils/reentrant_call_handler.rs Show resolved Hide resolved
contracts/src/token/erc20/utils/safe_erc20.rs Show resolved Hide resolved
qalisander
qalisander approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@qalisander qalisander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job guys!
There few comments left to be resolved, overall LGTM

bidzyyys
bidzyyys approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidzyyys bidzyyys merged commit 9d0a466 into OpenZeppelin:main Jan 7, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qalisander qalisander qalisander approved these changes

@bidzyyys bidzyyys bidzyyys approved these changes

@0xNeshi 0xNeshi Awaiting requested review from 0xNeshi 0xNeshi is a code owner

Assignees

@0xNeshi 0xNeshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: ERC20FlashMint extension
4 participants
@Ifechukwudaniel @0xNeshi @bidzyyys @qalisander