Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stacker): create project #450

Merged
merged 9 commits into from
Jul 22, 2024
Merged

chore(stacker): create project #450

merged 9 commits into from
Jul 22, 2024

Conversation

ahiuchingau
Copy link
Contributor

Project skeleton for the FLEX Stacker module.

Closes PLAT-445

@ahiuchingau ahiuchingau force-pushed the stacker_create-target branch from 3d7100b to a78f357 Compare July 15, 2024 19:51
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple inline things about changing names but lookin good!

@@ -0,0 +1,97 @@
name: 'Tempdeck Gen3 build/test'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 'Tempdeck Gen3 build/test'
name: 'stacker build/test'

stm32-modules/stacker/firmware/host_comms_task/usbd_desc.c Outdated Show resolved Hide resolved
@Laura-Danielle
Copy link
Contributor

Nitpick: could we call the project plate_stacker. I know that it's technically not the product name but I feel like it's more descriptive for firmware.

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahiuchingau ahiuchingau merged commit 94a1246 into edge Jul 22, 2024
12 of 13 checks passed
@ahiuchingau ahiuchingau deleted the stacker_create-target branch July 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants