fix(stacker): use actual serial number in usb serial number descriptor #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
requested changes
Dec 19, 2024
There was a problem hiding this comment.
We shouldn't #define an address like this if at all possible to avoid. We should either
- Traceably have the same address define be used in both writing and reading the serial, so it's impossible to get out of sync
- (preferred) define this as an extern; create a section in the linker script; set the value of the extern to the section address so it's harder to accidentally write something else on top of this
sfoster1
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the USB serial number string descriptor to correctly report the device's serial number stored in flash. This would allow us to easily identify a connected stacker without having to open up a serial connection.
We probably should consider fixing this descriptor for all of the stm32 modules at some point.