V6/code quality tools (#1890)

* Move testing dependencies to devDependencies

* Add prettier and pre-commit hooks

* Tight up lint rules

* Remove unused dependencies

* Added github action for linter

* Jobs naming updated

Co-authored-by: Djordje Kovacevic <[email protected]>

.eslintrc.js

@@ -3,40 +3,18 @@ module.exports = {
         es6: true,
         node: true,
     },
-    extends: 'airbnb',
+    extends: ['airbnb', 'prettier'],
     parserOptions: {
         sourceType: 'module',
         ecmaVersion: 2017,
     },
     rules: {
-        indent: [
-            'error',
-            4,
-        ],
-        'linebreak-style': [
-            'error',
-            'unix',
-        ],
+        'linebreak-style': ['error', 'unix'],
         camelcase: 0,
         'class-methods-use-this': 0,
-        'no-unused-vars': 0,
-        'no-return-assign': 0,
         'consistent-return': 0,
-        'no-var': 0,
-        'vars-on-top': 0,
-        'block-scoped-var': 0,
         'no-restricted-syntax': 0,
         'guard-for-in': 0,
-        'no-param-reassign': 0,
-        'no-underscore-dangle': 0,
-        'no-shadow': 0,
-        semi: [
-            'error',
-            'always',
-        ],
-        'no-console': [
-            'error',
-            { allow: ['warn', 'error', 'log'] },
-        ],
+        'no-console': 'warn',
     },
 };

.github/workflows/CHECK-lint.yml

@@ -0,0 +1,33 @@
+name: CHECK-lint
+
+#todo this test should be execute when opening PR to prerelease/release branches
+on: [pull_request]
+env:
+  NODE_ENV: test
+  ARTIFACTS_DIR: artifacts
+  CUCUMBER_ARTIFACTS_DIR: artifacts/cucumber
+jobs:
+  check-lint:
+    #todo think about locking the version - version should be the same as the one in official documentation
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [16.x]
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
+      - run: npm install
+      - run: mkdir -p $ARTIFACTS_DIR
+      - run: cp .origintrail_noderc.tests .origintrail_noderc
+      - run: sudo chmod -R 777 $ARTIFACTS_DIR
+      - run: mkdir -p $CUCUMBER_ARTIFACTS_DIR
+      - run: sudo chmod -R 777 $CUCUMBER_ARTIFACTS_DIR
+      - run: npm run lint;
+      - uses: actions/upload-artifact@v2
+        if: ${{ always() }}
+        with:
+          name: my-artifact
+          path: /home/runner/work/ot-node/ot-node/artifacts

.github/workflows/TEST-release.yml

@@ -8,7 +8,7 @@ env:
   CUCUMBER_ARTIFACTS_DIR: artifacts/cucumber
 jobs:
 
-  test:
+  test-release:
     #todo think about locking the version - version should be the same as the one in official documentation
     runs-on: ubuntu-latest
     services:

.github/workflows/TEST-unit.yml

@@ -8,7 +8,7 @@ env:
   CUCUMBER_ARTIFACTS_DIR: artifacts/cucumber
 jobs:
 
-  test:
+  test-unit:
     #todo think about locking the version - version should be the same as the one in official documentation
     runs-on: ubuntu-latest
 #    services:

.husky/.gitignore

@@ -0,0 +1 @@
+_

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+#npm run lint-staged

.lintstagedrc.json

@@ -0,0 +1,3 @@
+{
+  "*.{js, json}": ["prettier --write", "eslint"]
+}

.prettierrc

@@ -0,0 +1,9 @@
+{
+  "semi": true,
+  "printWidth": 100,
+  "singleQuote": true,
+  "trailingComma": "all",
+  "arrowParens": "always",
+  "tabWidth": 4,
+  "bracketSpacing": true
+}