Merge pull request #3527 from OriginTrail/v8/fix/enable-bid-suggestio…

…n-v0 Implement bid suggestion for backwards compatiblity
OriginTrail · Dec 18, 2024 · 8147705 · 8147705
2 parents a14f1ba + 7b57bc2
commit 8147705
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 32 deletions.
diff --git a/src/controllers/http-api/v0/bid-suggestion-http-api-controller-v0.js b/src/controllers/http-api/v0/bid-suggestion-http-api-controller-v0.js
@@ -1,43 +1,18 @@
 import BaseController from '../base-http-api-controller.js';
-import { LOW_BID_SUGGESTION } from '../../../constants/constants.js';
 
 class BidSuggestionController extends BaseController {
     constructor(ctx) {
         super(ctx);
-        this.repositoryModuleManager = ctx.repositoryModuleManager;
-        this.shardingTableService = ctx.shardingTableService;
+        this.blockchainModuleManager = ctx.blockchainModuleManager;
     }
 
-    // TODO: We should use new on chain calculation
     async handleRequest(req, res) {
-        if ((await this.repositoryModuleManager.getPeersCount(req.query.blockchain)) === 0) {
-            const message = `Unable to get bid suggestion. Empty sharding table for blockchain id: ${req.query.blockchain}`;
-            this.logger.error(message);
-            this.returnResponse(res, 406, {
-                code: 406,
-                message,
-            });
-            return;
-        }
-
-        let { bidSuggestionRange } = req.query;
         try {
-            if (!bidSuggestionRange) {
-                bidSuggestionRange = LOW_BID_SUGGESTION;
-            }
-            // TODO: This isn't backwards compatible
-            // const bidSuggestion = await this.shardingTableService.getBidSuggestion(
-            //     blockchain,
-            //     epochsNumber,
-            //     assertionSize,
-            //     contentAssetStorageAddress,
-            //     firstAssertionId,
-            //     hashFunctionId,
-            //     proximityScoreFunctionsPairId,
-            //     bidSuggestionRange,
-            // );
-
-            const bidSuggestion = {};
+            const { blockchain, epochsNumber, assertionSize } = req.body;
+            const bidSuggestion =
+                (await this.blockchainModuleManager.getStakeWeightedAverageAsk(blockchain)) *
+                epochsNumber *
+                assertionSize;
             this.returnResponse(res, 200, { bidSuggestion });
         } catch (error) {
             this.logger.error(`Unable to get bid suggestion. Error: ${error}`);

diff --git a/src/modules/blockchain/blockchain-module-manager.js b/src/modules/blockchain/blockchain-module-manager.js
@@ -262,8 +262,11 @@ class BlockchainModuleManager extends BaseModuleManager {
         return this.callImplementationFunction(blockchain, 'signMessage', [messageHash]);
     }
 
+    async getStakeWeightedAverageAsk(blockchain) {
+        return this.callImplementationFunction(blockchain, 'getStakeWeightedAverageAsk', []);
+    }
+
     // SUPPORT FOR OLD CONTRACTS
-
     async getLatestAssertionId(blockchain, assetContractAddress, tokenId) {
         return this.callImplementationFunction(blockchain, 'getLatestAssertionId', [
             assetContractAddress,

diff --git a/src/modules/blockchain/implementation/web3-service.js b/src/modules/blockchain/implementation/web3-service.js
@@ -1133,6 +1133,14 @@ class Web3Service {
         return wallet.signMessage(ethers.utils.arrayify(messageHash));
     }
 
+
+    async getStakeWeightedAverageAsk() {
+        return this.callContractFunction(
+            this.contracts.ShardingTableStorage,
+            'getStakeWeightedAverageAsk',
+            [],
+        );
+    }
     // SUPPORT FOR OLD CONTRACTS
 
     async getLatestAssertionId(assetContractAddress, tokenId) {