fix(pixel-edge): reject leading or trailing hyphens in compaction reason pattern - #5737
Open
Vishaaallll wants to merge 1 commit into
Open
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
…son pattern Signed-off-by: Vishaaallll <Vishaaallll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/pixel-edge/chat_context.py,project_contextvalidates compaction reasons againstr"^[a-z][a-z0-9-]*$". This regex permits trailing hyphens (e.g.overflow-), which violate the canonical hyphenated identifier schema used across Pixel telemetry and dashboard event routing.This surgical fix tightens the pattern to
r"^[a-z](?:[a-z0-9-]{0,94}[a-z0-9])?$", rejecting trailing hyphens while maintaining complete compatibility with single-character and hyphenated reason strings.Validation
"overflow-"was accepted on baseline.ValueError("invalid compaction detail")for trailing-hyphen reason strings.pixel-edge suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5730 touched route fingerprint normalization; zero overlap with compaction reason parsing.
Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Normalizes compaction identifier syntax. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. CI and unit checks pass.