fix(pixel-edge): reject unstripped whitespace in access mode target model - #5738
Open
Vishaaallll wants to merge 1 commit into
Open
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
…odel Signed-off-by: Vishaaallll <Vishaaallll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/pixel-edge/access_mode.py,valid_model_contract(value)permits spaces in the model name pattern[A-Za-z0-9._+:/ @(),=-]{0,255}. Consequently, names with trailing spaces like"qwen2.5:7b "pass validation, leading to mismatch against canonical route keys in provider coordination.This surgical fix verifies
value['model'] == value['model'].strip(), guaranteeing model names in contracts are whitespace-clean.Validation
"qwen2.5:7b "evaluated toTrueon baseline.Falsewhen model names carry leading or trailing whitespace.pixel-edge suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5731 handled model target name stripping in portal models; zero overlap with access mode contracts.
Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Restricts model contract name formatting. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. CI and unit checks pass.