fix(pixel-settings): enforce non-empty list of supportedThinkingLevels in capabilities - #5739
Open
Vishaaallll wants to merge 1 commit into
Open
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
…s in capabilities Signed-off-by: Vishaaallll <Vishaaallll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/bin/pixel_settings/contract.py,_capabilities(value)validates thatsupportedThinkingLevelsis a list of known thinking level strings, but permits an empty list[]. Every provider runtime must report at least one valid thinking level (at minimum["off"]). An empty list causes subsequent preview checks likeany(level != "off" for level in caps["supportedThinkingLevels"])to operate over an uninitialized capability state.This surgical fix requires
len(levels) > 0, raisingSettingsError("invalid-runtime-capabilities")ifsupportedThinkingLevelsis empty.Validation
supportedThinkingLevels: []was accepted by_capabilitieson baseline.SettingsError("invalid-runtime-capabilities")when empty.pixel-settings suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5723 allowed explicit thinking off when omitted; zero overlap with empty capabilities list enforcement.
Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Enforces provider capability declaration invariants. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. CI and unit checks pass.