Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an .env.example for NextJS #20

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

mcapodici
Copy link
Contributor

Other examples have a .env.example, but you can also make use of this for NextJS so I added some instructions.

@OvidijusParsiunas
Copy link
Owner

OvidijusParsiunas commented Oct 17, 2023

Thankyou very much for this PR and I absolutely agree that the NextJs example should have a .env.local file for local development.

I have added a comment for a small change in the README just to keep things simple and consistent with the other READMEs. Much appreciated!

@OvidijusParsiunas OvidijusParsiunas self-assigned this Oct 17, 2023
@OvidijusParsiunas OvidijusParsiunas added the documentation Improvements or additions to documentation label Oct 17, 2023
@OvidijusParsiunas
Copy link
Owner

Also, quick question. Are you able to self-approve this PR?
I have set the number of required approvals to 2 as I do not want malicious PRs to be self approved by the authors which could cause issues in the future. But if you can't I will lower it to 1. Thanks!

@mcapodici
Copy link
Contributor Author

I have updated the README now.

I can't self approve :-(

@OvidijusParsiunas OvidijusParsiunas merged commit 4957c21 into OvidijusParsiunas:main Oct 20, 2023
1 check passed
@OvidijusParsiunas
Copy link
Owner

Thankyou very much for your contribution @mcapodici!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants