Accessibility: Add semantics to textInput #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Adds role of textbox to textInput so screen-readers are told it is a text input ~2. Adds tabindex="0" to textInput so keyboard users can tab to it~ 3. Adds aria-label to textInput so screen-reader users know what it does All the above are because of limitations with being unable to add an `input` element and/or a `label`. OvidijusParsiunas#285
|
@imgiseverything |
OvidijusParsiunas
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2. Adds tabindex="0" to textInput so keyboard users can tab to itAll the above are because of limitations with being unable to add an
inputelement and/or alabel.note about
tabindexI opted not to add
tabindex=0because I noticed in our implementation on eurostar.com that this seemed to stop the focus styling from working on the#text-input-containerelement. Plus there seems to be some work in place to allow thedivto receive focus already so I felt it was not needed#285