Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validate dimension function to work correctly #118

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

Shalucik
Copy link
Member

Omschrijving

fix voor de dimensions validatie

Type verandering

(Verwijder de opties die niet relevant zijn.)

  • Minor change (typo, formatting, version bump)
  • Nieuwe feature
  • Verbetering oude feature
  • Bugfix
  • Refactor
  • Aanpassing van de configuratie
  • Breaking change

Checklist:

  • Ik heb de code in deze PR zelf nogmaals nagekeken
  • Ik heb mijn code beter achtergelaten dan dat ik het aantrof
  • De code is leesbaar en de moeilijke onderdelen zijn voorzien van commentaar
  • Ik heb de tests toegevoegd/uitgebreid indien nodig
  • Ik heb de tests gedraaid die de werking van mijn wijziging bewijst
  • De PDOK documentatie is bijgewerkt indien nodig.
  • Er zit geen gevoelig informatie in deze PR (wachtwoorden etc)

@Shalucik Shalucik requested a review from RoelvandenBerg May 27, 2024 10:04
Copy link
Collaborator

@RoelvandenBerg RoelvandenBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dit werkt (toch niet), zie andere PR

* fix docker and local docker-compose setup

* test if setup.cfg hack can be removed

* bugfix

* bugfix github action

* bugfix github action

* bugfix github action

* bugfix github action

* use GITHUB variables for gdalversion

* use GITHUB output variables for gdalversion

* use GITHUB output variables for gdalversion

* black

* limit test matrix

* limit test matrix

* limit test matrix

* limit test matrix

* limit test matrix

* limit test matrix

* update test matrix

* update test matrix
@Shalucik Shalucik requested a review from RoelvandenBerg May 28, 2024 07:06
@Shalucik Shalucik merged commit f70a123 into master May 28, 2024
9 checks passed
@Shalucik Shalucik deleted the fix-unit-tests branch May 28, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants