refactor(go): Polishing

internal/engine/resources.go

@@ -9,8 +9,8 @@ import (
 	"github.com/go-chi/chi/v5"
 )
 
+// Serve static assets either from local storage or through reverse proxy
 func newResourcesEndpoint(e *Engine) {
-	// Serve static assets either from local storage or through reverse proxy
 	resourcesDir := ""
 	if e.Config.Resources.Directory != nil {
 		resourcesDir = *e.Config.Resources.Directory
@@ -28,9 +28,9 @@ func newResourcesEndpoint(e *Engine) {
 	}
 }
 
-func proxy(reverseProxy func(w http.ResponseWriter, r *http.Request, target *url.URL, prefer204 bool, overwrite string),
-	resourcesURL string) func(w http.ResponseWriter, r *http.Request) {
+type reverseProxy func(w http.ResponseWriter, r *http.Request, target *url.URL, prefer204 bool, overwrite string)
 
+func proxy(rp reverseProxy, resourcesURL string) func(w http.ResponseWriter, r *http.Request) {
 	return func(w http.ResponseWriter, r *http.Request) {
 		resourcePath, _ := url.JoinPath("/", chi.URLParam(r, "*"))
 		target, err := url.ParseRequestURI(resourcesURL + resourcePath)
@@ -39,6 +39,6 @@ func proxy(reverseProxy func(w http.ResponseWriter, r *http.Request, target *url
 			RenderProblem(ProblemServerError, w)
 			return
 		}
-		reverseProxy(w, r, target, true, "")
+		rp(w, r, target, true, "")
 	}
 }

internal/ogc/features/domain/props_test.go

@@ -241,33 +241,3 @@ func TestSetRelation(t *testing.T) {
 		})
 	}
 }
-
-func TestKeys(t *testing.T) {
-	tests := []struct {
-		name     string
-		inOrder  bool
-		data     map[string]any
-		expected []string
-	}{
-		{
-			name:     "Unordered keys",
-			inOrder:  false,
-			data:     map[string]any{"key2": "value2", "key1": "value1"},
-			expected: []string{"key1", "key2"}, // sorted alphabetically
-		},
-		{
-			name:     "Ordered keys",
-			inOrder:  true,
-			data:     map[string]any{"key1": "value1", "key2": "value2"},
-			expected: []string{"key1", "key2"}, // insertion order maintained
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			p := NewFeaturePropertiesWithData(tt.inOrder, tt.data)
-			keys := p.Keys()
-			assert.Equal(t, tt.expected, keys)
-		})
-	}
-}