Add more unit tests

ogc/features/datasources/geopackage/geopackage.go

@@ -55,9 +55,7 @@ type GeoPackage struct {
 	queryTimeout     time.Duration
 }
 
-func NewGeoPackage(e *engine.Engine) *GeoPackage {
-	gpkgConfig := e.Config.OgcAPI.Features.Datasource.GeoPackage
-
+func NewGeoPackage(gpkgConfig engine.GeoPackage) *GeoPackage {
 	g := &GeoPackage{}
 	switch {
 	case gpkgConfig.Local != nil:

ogc/features/datasources/geopackage/geopackage_test.go

@@ -20,6 +20,43 @@ func init() {
 	pwd = path.Dir(filename)
 }
 
+func newAddressesGeoPackage() geoPackageBackend {
+	return newLocalGeoPackage(&engine.GeoPackageLocal{
+		GeoPackageCommon: engine.GeoPackageCommon{
+			Fid: "feature_id",
+		},
+		File: pwd + "/testdata/addresses.gpkg",
+	})
+}
+
+func TestNewGeoPackage(t *testing.T) {
+	type args struct {
+		config engine.GeoPackage
+	}
+	tests := []struct {
+		name                        string
+		args                        args
+		wantNrOfFeatureTablesInGpkg int
+	}{
+		{
+			name: "open local geopackage",
+			args: args{
+				engine.GeoPackage{
+					Local: &engine.GeoPackageLocal{
+						File: pwd + "/testdata/addresses.gpkg",
+					},
+				},
+			},
+			wantNrOfFeatureTablesInGpkg: 3,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equalf(t, tt.wantNrOfFeatureTablesInGpkg, len(NewGeoPackage(tt.args.config).featureTableByID), "NewGeoPackage(%v)", tt.args.config)
+		})
+	}
+}
+
 func TestGeoPackage_GetFeatures(t *testing.T) {
 	type fields struct {
 		backend          geoPackageBackend
@@ -177,15 +214,6 @@ func TestGeoPackage_GetFeatures(t *testing.T) {
 	}
 }
 
-func newAddressesGeoPackage() geoPackageBackend {
-	return newLocalGeoPackage(&engine.GeoPackageLocal{
-		GeoPackageCommon: engine.GeoPackageCommon{
-			Fid: "feature_id",
-		},
-		File: pwd + "/testdata/addresses.gpkg",
-	})
-}
-
 func TestGeoPackage_GetFeature(t *testing.T) {
 	type fields struct {
 		backend          geoPackageBackend

ogc/features/main.go

@@ -38,7 +38,7 @@ func NewFeatures(e *engine.Engine, router *chi.Mux) *Features {
 	if e.Config.OgcAPI.Features.Datasource.FakeDB {
 		datasource = fakedb.NewFakeDB()
 	} else if e.Config.OgcAPI.Features.Datasource.GeoPackage != nil {
-		datasource = geopackage.NewGeoPackage(e)
+		datasource = geopackage.NewGeoPackage(*e.Config.OgcAPI.Features.Datasource.GeoPackage)
 	}
 	e.RegisterShutdownHook(datasource.Close)