Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html): add explicit submit/reset buttons for feature filters ins… #212

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

rkettelerij
Copy link
Collaborator

Description

Add explicit submit/reset buttons for feature filters instead of onchange listeners.
More WCAG compliant + more clear for the user.

Type of change

  • Improvement of existing feature

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

…tead of onchange listeners.

More WCAG compliant + more clear for the user.
@rkettelerij rkettelerij mentioned this pull request Jul 5, 2024
6 tasks
@rkettelerij rkettelerij merged commit 344e21f into master Jul 5, 2024
6 checks passed
@rkettelerij rkettelerij deleted the features-form branch July 5, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants