Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(viewer): Read metadata gokoala title items from style #226

Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat(viewer): Read metadata gokoala title items from style #226

merged 1 commit into from
Sep 2, 2024

Conversation

rkettelerij
Copy link
Collaborator

@rkettelerij rkettelerij commented Sep 2, 2024 •
edited
Loading

Description

Read metadata gokoala title items from style + Upgrade Angular. Replaces #225 by @JLSchaap

Type of change

  • Upgrade
  • Bugfix

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@rkettelerij rkettelerij mentioned this pull request Sep 2, 2024
Closed
@JLSchaap JLSchaap self-requested a review September 2, 2024 09:29
@rkettelerij rkettelerij merged commit dbb64d1 into master Sep 2, 2024
5 checks passed
@rkettelerij rkettelerij deleted the metadata-style branch September 2, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLSchaap JLSchaap JLSchaap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkettelerij @JLSchaap