Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(filters): Consolidate property filters logic to a single func. #236

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

rkettelerij
Copy link
Collaborator

Description

Instead of having both "configurePropertyFiltersWithAllowedValues" and "getConfiguredPropertyFilters".

Type of change

  • Refactoring

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

Instead of having both "configurePropertyFiltersWithAllowedValues" and "getConfiguredPropertyFilters".
@rkettelerij rkettelerij merged commit c037a9b into master Sep 17, 2024
5 checks passed
@rkettelerij rkettelerij deleted the dedup branch September 17, 2024 11:40
@rkettelerij rkettelerij mentioned this pull request Sep 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants