Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add preview url to dataset thumbnail on landing page #257

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat: add preview url to dataset thumbnail on landing page #257

merged 2 commits into from
Nov 28, 2024

Conversation

rkettelerij
Copy link
Collaborator

Description

As requested by @JLSchaap

Type of change

  • Minor change (typo, formatting, version bump)

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@rkettelerij
feat: add preview url to dataset thumbnail on landing page
dbfc1a2
@rkettelerij
fix: revert adding span with breadcrumb names since.
f78617a 
Was added since Google Rich Results Test now displays as name. But it does cause invalid HTML since <ol> isn't allowed to have a non-<li> child
@rkettelerij rkettelerij merged commit 0f2c3f8 into master Nov 28, 2024
5 checks passed
@rkettelerij rkettelerij deleted the preview-url-landingpage branch November 28, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roelarents roelarents roelarents approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkettelerij @roelarents