Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup (Cloud-Backed) SQLite backend for reading GeoPackages #64

Merged
merged 16 commits into from
Oct 17, 2023
Merged

Setup (Cloud-Backed) SQLite backend for reading GeoPackages #64

merged 16 commits into from
Oct 17, 2023

Conversation

rkettelerij
Copy link
Collaborator

@rkettelerij rkettelerij commented Oct 9, 2023 •
edited
Loading

Omschrijving

https://dev.kadaster.nl/jira/browse/PDOK-15675

Type verandering

  • Nieuwe feature

Checklist:

  • Ik heb de code in deze PR zelf nogmaals nagekeken
  • Ik heb mijn code beter achtergelaten dan dat ik het aantrof
  • De code is leesbaar en de moeilijke onderdelen zijn voorzien van commentaar
  • Ik heb de tests toegevoegd/uitgebreid indien nodig
  • Ik heb de tests gedraaid die de werking van mijn wijziging bewijst
  • De PDOK documentatie is bijgewerkt indien nodig.
  • Er zit geen gevoelig informatie in deze PR (wachtwoorden etc)

@rkettelerij rkettelerij force-pushed the geopackage-backend branch 5 times, most recently from 7d40ef5 to 4796a67 Compare October 10, 2023 11:02
@rkettelerij rkettelerij marked this pull request as ready for review October 10, 2023 11:03
@rkettelerij rkettelerij force-pushed the geopackage-backend branch 4 times, most recently from f7729e8 to 18a0297 Compare October 13, 2023 09:20
roelarents
roelarents approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@roelarents roelarents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

README.md Outdated Show resolved Hide resolved
@rkettelerij rkettelerij merged commit 455f896 into master Oct 17, 2023
6 checks passed
@rkettelerij rkettelerij deleted the geopackage-backend branch October 17, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roelarents roelarents roelarents approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkettelerij @roelarents