Cursor gaps #71
Merged
Cursor gaps #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ids. Also remove fakedb support since we now support local geopackages. This makes maintenance easier since we don't need to keep fakedb support working. Also create PostGIS dummy to demonstrate extensibility.
…users change filters (limit, bbox) during pagination, since the latter isn't allowed.
…incrementing feature ids and also guard against changing query params during pagination.
rkettelerij
force-pushed
the
cursor-gaps
branch
from
1b75f40 to
96c8375
Compare
kad-korpem
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omschrijving
Kunnen nu omgaan met gaten in de feature ids. Feature ids moet wel opvolgend zijn maar mogen gaten bevatten en hoeven ook niet bij 0 of 1 te beginnen. Tevens voorziening ingebouwd dat als iemand onverhoopt de query params aanpast tijdens het pagineren (wat niet zou mogen wat je moet een next of prev link volgen) dat de cursor naar de eerste pagina gaat en je vanuit daar opnieuw kan beginnen met pagineren.
Tevens e.e.a aangepast zodat de next/prev links altijd de juiste filters bevatten.
Verder: FakeDB is komen te vervallen, want we hebben nu local gpkg support.
https://dev.kadaster.nl/jira/browse/PDOK-15724
Type verandering
Checklist: