Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining parts of OAF Part 2 CRS spec #84

Merged
merged 26 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e5beff9
Update readme + fix typo
rkettelerij Dec 1, 2023
ea319fe
Add Content-Crs header
rkettelerij Dec 1, 2023
776cfbd
Use constants for HTTP headers
rkettelerij Dec 1, 2023
0e94bb9
Rename GH action
rkettelerij Dec 4, 2023
c198d30
Remove unused extent
rkettelerij Dec 4, 2023
6deaf91
Remove unused components (overlaps with OGC API Features)
rkettelerij Dec 4, 2023
8277209
Add OGC API Features part 2 + fix multiple collections with same name…
rkettelerij Dec 5, 2023
ff92c25
Tidy + upgrade selected deps
rkettelerij Dec 6, 2023
a1759e3
Turn multiple OGC APIs for a single collection example into a unit te…
rkettelerij Dec 6, 2023
43f3a5b
Add extra test
rkettelerij Dec 6, 2023
3566f82
Add OpenAPI validation to OGC API Features
rkettelerij Dec 8, 2023
c82abd5
Add extra test
rkettelerij Dec 12, 2023
7afed84
Tidy
rkettelerij Dec 12, 2023
e01d29b
Fix tests
rkettelerij Dec 12, 2023
f02e6ba
Add query params to JSON link, to switch to correct GeoJSON when filt…
rkettelerij Dec 12, 2023
dbbae4f
Add support for multiple output formats to global navigation
rkettelerij Dec 12, 2023
90b3cd7
Use stable output
rkettelerij Dec 12, 2023
bea4f57
Create working Features collection page, remove dummy text/links
rkettelerij Dec 12, 2023
1e5ff6a
Typo
rkettelerij Dec 12, 2023
39318f9
Linting
rkettelerij Dec 12, 2023
b858b0e
Extra test case + polishing
rkettelerij Dec 12, 2023
b64ff3a
Move more headers to constants
rkettelerij Dec 12, 2023
d52c7ea
Replace bbox from OAF spec 1.0.1 with 1.0.0 version due to validator,…
rkettelerij Dec 13, 2023
ddc5f9f
Return valid empty response
rkettelerij Dec 13, 2023
7b0a9c8
Add new validation report
rkettelerij Dec 13, 2023
47a09dd
Add crs to link
rkettelerij Dec 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,34 +1,34 @@
---
name: deploy web components
on:
push:
branches: ["master"]
pull_request:
branches: ["master"]
defaults:
run:
working-directory: ./viewer
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: "npm"
cache-dependency-path: "./viewer/package-lock.json"
- run: npm ci
- name: Deploy
run: npm run deploy
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
---
name: deploy viewer
on:
push:
branches: ["master"]
pull_request:
branches: ["master"]

defaults:
run:
working-directory: ./viewer

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: "npm"
cache-dependency-path: "./viewer/package-lock.json"
- run: npm ci
- name: Deploy
run: npm run deploy
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/cypress-ts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ defaults:
run:
working-directory: ./viewer
jobs:
cypres-ts:
cypress-ts:
runs-on: ubuntu-latest

strategy:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-ts.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: lint (web/typescript)
name: lint (web/ts)
on:
push:
branches:
Expand Down
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@ _Cloud Native OGC APIs server, written in Go._
[![Lint (go)](https://github.com/PDOK/gokoala/actions/workflows/lint-go.yml/badge.svg)](https://github.com/PDOK/gokoala/actions/workflows/lint-go.yml)
[![Lint (ts)](https://github.com/PDOK/gokoala/actions/workflows/lint-ts.yml/badge.svg)](https://github.com/PDOK/gokoala/actions/workflows/lint-ts.yml)
[![Go Report Card](https://goreportcard.com/badge/github.com/PDOK/gokoala)](https://goreportcard.com/report/github.com/PDOK/gokoala)
[![GitHub
license](https://img.shields.io/github/license/PDOK/gokoala)](https://github.com/PDOK/gokoala/blob/master/LICENSE)
[![Docker
Pulls](https://img.shields.io/docker/pulls/pdok/gokoala.svg)](https://hub.docker.com/r/pdok/gokoala)
[![Coverage (go)](https://github.com/PDOK/gokoala/wiki/coverage.svg)](https://raw.githack.com/wiki/PDOK/gokoala/coverage.html)
[![GitHub license](https://img.shields.io/github/license/PDOK/gokoala)](https://github.com/PDOK/gokoala/blob/master/LICENSE)
[![Docker Pulls](https://img.shields.io/docker/pulls/pdok/gokoala.svg)](https://hub.docker.com/r/pdok/gokoala)

## Description

Expand Down Expand Up @@ -153,12 +152,12 @@ Design principles:
Install [golangci-lint](https://golangci-lint.run/usage/install/) and run `golangci-lint run`
from the root.

### Viewer Web Component
### Viewer

GoKoala includes a [viewer](viewer) which is available
as a Web Component for embedding in HTML pages. To use the vector tile viewer locally when running
GoKoala outside Docker execute: `hack/build-local-viewer.sh`. This will build the viewer and add
it to the GoKoala assets.
as a [Web Component](https://developer.mozilla.org/en-US/docs/Web/API/Web_components) for embedding in HTML pages.
To use the viewer locally when running GoKoala outside Docker execute: `hack/build-local-viewer.sh`. This will
build the viewer and add it to the GoKoala assets.

Note this is only required for local development. When running GoKoala as a container this is
already being taken care of when building the Docker container image.
Expand Down Expand Up @@ -203,6 +202,7 @@ compliance when available. In the case of OGC API Features follow these steps:
- Start a new test session in the TEAM Engine against http://localhost:8080 (or http://host.docker.internal:8080).
- More details in the [features conformance test suite](https://opengeospatial.github.io/ets-ogcapi-features10/).
- Publish test results HTML report in [docs](./docs/ogc-features-test-report) and list below.
- Test results on [13-12-2023](https://htmlpreview.github.io/?https://github.com/PDOK/gokoala/blob/master/docs/ogc-features-test-report/20231213.html)
rkettelerij marked this conversation as resolved.
Show resolved Hide resolved
- Test results on [27-09-2023](https://htmlpreview.github.io/?https://github.com/PDOK/gokoala/blob/master/docs/ogc-features-test-report/20230927.html)

## Misc
Expand Down
2 changes: 1 addition & 1 deletion assets/i18n/active.en.toml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Extent = "Geographic extent"
GoTo = "Go to the"
ViewIn = "View in the"
Browse = "Browse through the"
FeaturesExplanation = "TODO Explain here GeoJSON vs JSON-FG"
FeaturesExplanation = "GeoJSON is an open and widely accepted format for feature data and the first choice for many (web) applications. However, it formally only supports the WGS84 projection. JSON-FG is an extension of GeoJSON and does offer official support for other projections. Since JSON-FG is a recent development, from a compatibility point of view GeoJSON is also offered in other projections for the time being."

# Features page
Geometry = "geometry"
Expand Down
2 changes: 1 addition & 1 deletion assets/i18n/active.nl.toml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Extent = "Geografische begrenzing"
GoTo = "Ga naar de"
ViewIn = "Bekijk in de"
Browse = "Blader door de"
FeaturesExplanation = "Uitleg over welke JSON, wanneer kies je voor GeoJSON en wanneer voor JSON-FG. Verschil tussen projecties, etc."
FeaturesExplanation = "GeoJSON is een open en breed geaccepteerd formaat voor feature data en voor veel (web)toepassingen de eerste keus. Formeel ondersteunt het echter alleen de WGS84 projectie. JSON-FG is een uitbreiding op GeoJSON en biedt officiële ondersteuning voor andere projecties. Aangezien JSON-FG een recente ontwikkeling is wordt er vanuit compatibiliteit oogpunt vooralsnog ook GeoJSON in andere projecties aangeboden."

# Features page
Geometry = "geometrie"
Expand Down
Loading
Loading