Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack) add rate limiting #6

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat(slack) add rate limiting #6

merged 2 commits into from
Jun 25, 2024

Conversation

rkettelerij
Copy link
Collaborator

Description

Avoid messages like:

"error": "slack rate limit exceeded, retry after 1s"}
2024-06-24 18:25:39.149Z github.com/PDOK/uptime-operator/internal/service.(*Slack).Send
2024-06-24 18:25:39.149Z        /workspace/internal/service/slack.go:31
2024-06-24 18:25:39.149Z github.com/PDOK/uptime-operator/internal/service.(*UptimeCheckService).logMutation
2024-06-24 18:25:39.149Z        /workspace/internal/service/service.go:135
2024-06-24 18:25:39.149Z github.com/PDOK/uptime-operator/internal/service.(*UptimeCheckService).Mutate
2024-06-24 18:25:39.149Z        /workspace/internal/service/service.go:79
2024-06-24 18:25:39.149Z github.com/PDOK/uptime-operator/internal/controller.(*IngressRouteReconciler).Reconcile```

Type of change

  • Improvement of existing feature

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@rkettelerij rkettelerij merged commit 45b8a1a into master Jun 25, 2024
2 checks passed
@rkettelerij rkettelerij deleted the slack-ratelimit branch June 25, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants