Repository navigation
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
zlataovce
reviewed
Oct 8, 2026
Comment on lines
+249
to
+250
| "default" defaults to 5. Set to 0 to disable the catchup. A value of 1 has the same effect | ||
| as 0, so the lowest value that enables the catchup is 2. |
Member
There was a problem hiding this comment.
Suggested change
| "default" defaults to 5. Set to 0 to disable the catchup. A value of 1 has the same effect | |
| as 0, so the lowest value that enables the catchup is 2. | |
| "default" defaults to 5. Set to 1 or lower to disable the catchup. |
something feels iffy about this behavior though
Contributor
There was a problem hiding this comment.
It’s really not. This is the amount of ticks that should happen during the next tick after a missed tick, so a number of 1, means the next tick should have to pass as it normally would (1 ticks in 1 tick), whereas a value of 5 would mean, 5 ticks have to pass in 1 tick. Atleast something around those lines
Contributor
There was a problem hiding this comment.
However I do think the option is poorly named or atleast implemented, on one hand it is correct according to the implementation catchup-ticks, but on the other hand its not immediately obvious to a server admin that has no knowledge of the internals and how they work.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #784
Adds a sentence to the
misc.catchup-ticksdescription inpaper-global.ymlsaying that1has the same effect as0, so the lowest value that enables the catchup is2.This documents the current behaviour, where the configured value is clamped with
Math.max(1, catchupTicks.or(5))in the tick loop. If the behaviour is changed in Paper instead, I am happy to update this to match.Checked with
pnpm run format:checklocally.