Skip to content

Add missing duration flag to Bladefall, Smoke Mine and Cold Snap #10384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lemmertz wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −4
Open

Add missing duration flag to Bladefall, Smoke Mine and Cold Snap #10384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Data/Skills/act_dex.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2535,6 +2535,7 @@ skills["Bladefall"] = {
baseFlags = {
spell = true,
area = true,
duration = true,
},
baseMods = {
skill("radius", 44),
Expand Down Expand Up @@ -2802,6 +2803,7 @@ skills["BladefallAltZ"] = {
baseFlags = {
spell = true,
area = true,
duration = true,
},
qualityStats = {
{ "active_skill_base_area_of_effect_radius", 0.15 },
Expand Down Expand Up @@ -14223,6 +14225,7 @@ skills["SmokeMine"] = {
mine = true,
area = true,
buff = true,
duration = true,
},
baseMods = {
skill("radius", 18),
Expand Down
1 change: 1 addition & 0 deletions src/Data/Skills/act_int.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2821,6 +2821,7 @@ skills["ColdSnap"] = {
baseFlags = {
spell = true,
area = true,
duration = true,
},
baseMods = {
skill("dotIsArea", true),
Expand Down
6 changes: 3 additions & 3 deletions src/Export/Skills/act_dex.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ return function(skills, mod, flag, skill)
#mods

#skill Bladefall
#flags spell area
#flags spell area duration
statMap = {
["quality_display_bladefall_is_gem"] = {
--Display only
Expand Down Expand Up @@ -513,7 +513,7 @@ return function(skills, mod, flag, skill)
#mods

#skill BladefallAltZ
#flags spell area
#flags spell area duration
preDamageFunc = function(activeSkill, output)
activeSkill.skillData.hitTimeOverride = activeSkill.skillData.hitFrequency / (1 + activeSkill.skillData.incVolleyFrequency / 100)
end,
Expand Down Expand Up @@ -2933,7 +2933,7 @@ return function(skills, mod, flag, skill)
#mods

#skill SmokeMine
#flags spell mine area buff
#flags spell mine area buff duration
statMap = {
["base_movement_velocity_+%"] = {
mod("MovementSpeed", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff" }),
Expand Down
2 changes: 1 addition & 1 deletion src/Export/Skills/act_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ return function(skills, mod, flag, skill)
#mods

#skill ColdSnap
#flags spell area
#flags spell area duration
#baseMod skill("dotIsArea", true)
#baseMod skill("radiusLabel", "Initial Burst:")
#baseMod skill("radiusSecondaryLabel", "Initial Chilled Ground:")
Expand Down