Allow device to configure conversion to numpy and use of pure_callback
#6788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
…I/pennylane into no-interface-boundary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6788 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 476 476
Lines 45232 45242 +10
=======================================
+ Hits 45055 45065 +10
Misses 177 177 ☔ View full report in Codecov by Sentry. |
andrijapau
reviewed
Jan 9, 2025
Comment on lines
+710
to
+711
| out = jitted_qnode1(0.123) | ||
| print(out) |
There was a problem hiding this comment.
Suggested change
| out = jitted_qnode1(0.123) | |
| print(out) | |
| jitted_qnode1(0.123) |
andrijapau
reviewed
Jan 9, 2025
Comment on lines
+9
to
+13
| * Devices can now configure whether or not the data is converted to numpy and `jax.pure_callback` | ||
| is used by the new `ExecutionConfig.convert_to_numpy` property. Finite shot executions | ||
| on `default.qubit` can now be jitted end-to-end, even with parameter shift. | ||
| [(#6788)](https://github.com/PennyLaneAI/pennylane/pull/6788) | ||
|
|
There was a problem hiding this comment.
Suggested change
| * Devices can now configure whether or not the data is converted to numpy and `jax.pure_callback` | |
| is used by the new `ExecutionConfig.convert_to_numpy` property. Finite shot executions | |
| on `default.qubit` can now be jitted end-to-end, even with parameter shift. | |
| [(#6788)](https://github.com/PennyLaneAI/pennylane/pull/6788) | |
| * Devices can now configure whether or not the data is converted to numpy enabling `jax.pure_callback` to be used by the new `ExecutionConfig.convert_to_numpy` property. Finite shot executions on `default.qubit` can now be jitted end-to-end leading to performance improvements, even with parameter shift. | |
| [(#6788)](https://github.com/PennyLaneAI/pennylane/pull/6788) | |
andrijapau
reviewed
Jan 9, 2025
| @@ -581,6 +591,12 @@ def _setup_execution_config(self, execution_config: ExecutionConfig) -> Executio | |||
| """ | |||
| updated_values = {} | |||
|
|
|||
| updated_values["convert_to_numpy"] = ( | |||
| execution_config.interface.value not in {"jax", "jax-jit"} | |||
There was a problem hiding this comment.
Do we want to continue using the Interface enum instead?
Suggested change
| execution_config.interface.value not in {"jax", "jax-jit"} | |
| execution_config.interface not in {qml.math.Interface.JAX, qml.math.Interface.JAX_JIT} |
astralcai
reviewed
Jan 9, 2025
astralcai
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
While we have logic for sampling with jax, it does not really integrate very well into the workflow. While you can technically set
diff_method=Noneright now and jit the execution end-to-end, trying to jitdiff_method=Nonewill cause incomprehensible error messages on non-DQ devices.We want to forbid differentiation
diff_method=None, but keep a way to jit a finite shot execution.Description of the Change:
In order to allow jitting finite shot executions, we need a way for the device to be able to configure whether or not the data is converted to numpy. To do so, we simply add another property to the
ExecutionConfig,convert_to_numpy. IfFalse, then we will not use apure_callbackto convert the parameters to numpy. IfTrue, we use apure_callbackand convert the parameters to numpy.Benefits:
Speed ups due to being able to jit the entire execution.
Possible Drawbacks:
ExecutionConfiggets an addtional property, making it more complicated.Related GitHub Issues:
Fixes #6054 Fixes #3259 Blocks #6770