[SDKNEW-3192] url decoding reserved characters & filter by custom function #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ori-gold-px
force-pushed
the
feature/url-decode-reserved-characters
branch
from
d6f1b78 to
1ffcc21
Compare
chen-zimmer-px
approved these changes
Nov 12, 2023
| if sum(1 for _ in filter(lambda whitelist_route_item: re.match(whitelist_route_item, request.path), config.whitelist_routes_regex)) > 0 or \ | ||
| sum(1 for _ in filter(lambda whitelist_route_item: request.path == whitelist_route_item, config.filter_by_route)) > 0: | ||
| return True | ||
| if config.filter_by_custom_function: |
There was a problem hiding this comment.
Should the custom function be the first condition?
There was a problem hiding this comment.
No - it should be the last condition in case other (simpler) configurations filter it out first and we can prevent needing to call the function unnecessarily
chen-zimmer-px
requested changes
Nov 12, 2023
ori-gold-px
force-pushed
the
feature/url-decode-reserved-characters
branch
from
c799bb3 to
462d3d0
Compare
ori-gold-px
force-pushed
the
feature/url-decode-reserved-characters
branch
from
3476881 to
6e5362b
Compare
chen-zimmer-px
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perimeterx.atlassian.net/browse/SDKNEW-3192