Upgrade decidim to 0.28 #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fblupi
reviewed
Jan 14, 2025
config/initializers/decidim_icons.rb
Outdated
| @@ -0,0 +1,4 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| Decidim.icons.register(name: "pencil-line", icon: "pencil-line", category: "system", description: "", engine: :core) | |||
There was a problem hiding this comment.
We shouldn't need to do this. We should find where we are using those icons and replace them with existing ones. Because you will see an empty one if the icon is not registered.
There was a problem hiding this comment.
Removed.
In development_app:
However, still the same error in the test_app and subsequent tests...
fblupi
reviewed
Jan 14, 2025
There was a problem hiding this comment.
You don't need this file as you are not updating an instance
fblupi
reviewed
Jan 14, 2025
| @@ -192,5 +192,6 @@ | |||
| "dependencies": { | |||
| "@rails/actioncable": "6.1.7", | |||
| "select2": "^4.1.0-rc.0" | |||
| } | |||
| }, | |||
| "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | |||
There was a problem hiding this comment.
Why installing yarn here? You should not include this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35