Repository navigation
Fix offset by one in RadiusOutlierRemoval<PCLPointCloud> and speed up radius search. Fixes #2816 - #6488
Open
Sree0211 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
applyFilter(PCLPointCloud2&):usek <= min_pts_radius_instead ofk < min_pts_radius_. The radius search result includes the query point itself, so this makes thePCLPointCloud2specialisation consistent with the templated implementation and with the documentation ofsetMinNeighborsInRadius.min_pts_radius_ + 1as max_nn to bothradiusSearchcalls, so the search stops once enough nieghbors are found.(RadiusOutlierRemovalPCLPointCloud2).RadiusOutlierRemovaltest case as thePCLPointCloud2section usedsetMinNeightborsInradius(15)to get the same 307 points as the templated part with14. Both now use14. (Commented out this current test section)Testing:
test_filterslocally in Windows (MSVC). Before updating the unit test setup tests fail, after the fix all filter tests pass.command: test_filters.exe test\bun0.pcd test\milk_cartoon_all_small_colorx.pcd --gtest_filter=RadiusOutlierRemoval*After Fix: