remove Graph and PersistentGraph from Prop #1902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
add support for Array in Prop and PropType remove Graph and PersistentGraph from Prop
fabianmurariu
force-pushed
the
remove_graph_prop
branch
from
5d5bb62 to
eda883b
Compare
ljeub-pometry
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove Graph and PersistentGraph from Prop
Add Arrow arrays to Prop
Why are the changes needed?
Graph and Persistent graph create a circular dependency between Prop and Graph, also no one uses them
Does this PR introduce any user-facing change? If yes is this documented?
Yes, users can no longer set Graph and PersistentGraph as properties
How was this patch tested?
Tests
Are there any further changes required?
Adding PropRef and possibly moving Prop to raphtory-api