Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 35 : Added Email Existence Check via OTP and Verification Code During Sign-up #49

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

sidgureja7803
Copy link

1- Email Verification via OTP:
Integrated Node-Mailer to send an OTP for verifying the user's email during sign-up.
Users will receive a verification code in their email, ensuring that only valid email addresses can be used for account creation.

2- OTP Verification and Validity:
Added OTP validation logic in the backend:
The OTP must match the one sent to the user's email for successful verification.
OTP is valid for 10 minutes to enhance security.
Updated the user model schema to include a verified field, which is set to true only when the OTP is correctly entered.

3- New OTP Input Page:
Added a new page that appears after the user presses the "Sign-up" button, allowing the user to enter the OTP received via email.
Impact: This feature enhances the security of the sign-up process by ensuring that users can only register with valid, verified email addresses.

NOTE -
Make sure that the .env file is setup properly ( RAZRORAPY, GMAIL ID AND PASSWORD FOR Node-mailer to function )
and firebase details as well in client folder .env
Thank you

@PorePranav, this time I have kept in mind what you told me yestarday in, inline comments.
I have not used a separate file for email service in the utils folder.
I have used, a separate file to implement the verifyMail useMutation
I have not changed any paths, port numbers or package scripts.

Please approve this Pull Request.

Copy link

vercel bot commented Oct 21, 2024

@sidgureja7803 is attempting to deploy a commit to the porepranav's projects Team on Vercel.

A member of the Team first needs to authorize it.

@sidgureja7803
Copy link
Author

@PorePranav , this time I have kept in mind what you told me yestarday in, inline comments.
I have not used a separate file for email service in the utils folder.
I have used, a separate file to implement the verifyMail useMutation
I have not changed any paths, port numbers or package scripts.
I have not changed the project library versions in the package.json file

Please approve this Pull Request.

@sidgureja7803
Copy link
Author

@PorePranav any reply ??

@sidgureja7803
Copy link
Author

@PorePranav reply ASAP
i worked for one week on this issue, for integrating the OTP verification service.
And now you have refused to merge my PR. Please tell me, whether you will merge it or not ??
so that i can work on other repos labeled under hacktoberfest.
Today is 22nd oct and the hacktoober fest is about to end.

@PorePranav
Copy link
Owner

@PorePranav reply ASAP i worked for one week on this issue, for integrating the OTP verification service. And now you have refused to merge my PR. Please tell me, whether you will merge it or not ?? so that i can work on other repos labeled under hacktoberfest. Today is 22nd oct and the hacktoober fest is about to end.

You need to have some patience after raising a PR, I'm not free 24x7 just to check if there are any new PRs. As far as your PR is concerned I'll take a look at it in a day or two, as I am busy with some other tasks. Also kindly don't submit PRs just for the sake of completing Hacktober fest, I am not saying your PR is or low quality, but there are some project standards and structures that need to be followed which was missing in your earlier PR which is why I wasn't able to merge it.

Thank you!

@sidgureja7803
Copy link
Author

@PorePranav reply ASAP i worked for one week on this issue, for integrating the OTP verification service. And now you have refused to merge my PR. Please tell me, whether you will merge it or not ?? so that i can work on other repos labeled under hacktoberfest. Today is 22nd oct and the hacktoober fest is about to end.

You need to have some patience after raising a PR, I'm not free 24x7 just to check if there are any new PRs. As far as your PR is concerned I'll take a look at it in a day or two, as I am busy with some other tasks. Also kindly don't submit PRs just for the sake of completing Hacktober fest, I am not saying your PR is or low quality, but there are some project standards and structures that need to be followed which was missing in your earlier PR which is why I wasn't able to merge it.

Thank you!

@PorePranav Any update ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants