Add function to create and manage Guests #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alagoutte
requested changes
Oct 11, 2018
PowerArubaCP/Public/Guest.ps1
Outdated
| .DESCRIPTION | ||
| Add Guest account on Aruba ClearPass | ||
| .EXAMPLE | ||
| Add-ArubaCPGuest -username -company -mail -role [-enable] [-expire] |
There was a problem hiding this comment.
remove [-enable] -expire]
There was a problem hiding this comment.
and make a really example
PowerArubaCP/Public/Guest.ps1
Outdated
| Add-ArubaCPGuest -username -company -mail -role [-enable] [-expire] | ||
| Add the guest account with parameters. | ||
| .EXAMPLE | ||
| Add-ArubaCPGuest -username matthew -company "Interstellar & Co" -mail [email protected] -role 2 -enable True |
There was a problem hiding this comment.
Add Power and Aruba user ? :)
There was a problem hiding this comment.
About the name of user add on your example ;)
| [Parameter(Mandatory = $true)] | ||
| [int]$role, | ||
| [Parameter(Mandatory = $false)] | ||
| [ValidateSet ("True", "False")] |
|
|
||
| $guest | add-member -name "role_id" -membertype NoteProperty -Value $role | ||
|
|
||
| if ( $PsBoundParameters.ContainsKey('enable')) |
There was a problem hiding this comment.
use switch type it will be more easy
PowerArubaCP/Public/Guest.ps1
Outdated
| .DESCRIPTION | ||
| Set information about a guest account based on his username on Aruba ClearPass. | ||
| .EXAMPLE | ||
| Set-ArubaCPGuest -username test [-company] [-mail] [-role (1/2/3)] [-enable (true/false)] [-expire (hour/day/week/month/year)]/ |
| [ValidateRange (1,3)] | ||
| [int]$role, | ||
| [Parameter(Mandatory = $false)] | ||
| [ValidateSet ("true", "false")] |
PowerArubaCP/Public/Guest.ps1
Outdated
| [ValidateSet ("true", "false")] | ||
| [string]$enable, | ||
| [Parameter(Mandatory = $false)] | ||
| [String]$expire |
There was a problem hiding this comment.
use direct timestamp value
There was a problem hiding this comment.
directly send the timestamp to the function (the conversion number of day to timestamp need to be make by user on the script but not in this module)
alagoutte
reviewed
Oct 18, 2018
PowerArubaCP/Public/Guest.ps1
Outdated
|
|
||
| if ( $PsBoundParameters.ContainsKey('role')) | ||
| { | ||
| switch( $role ) { |
There was a problem hiding this comment.
missing that, only need to pass the role id/number
alagoutte
requested changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.