[Copilot]

AvoidValidateRangeTypeMismatch missed integral bounds expressed as static constants and could warn for unrelated custom attributes with similar names.

• Boundary detection: Recognize public static literal integral fields without invoking property getters.
• Attribute matching: Require the resolved System.Management.Automation.ValidateRangeAttribute type.

param([double][ValidateRange(0, [int]::MaxValue)]$Value)

[Copilot]

🟡 Changes recommended

The rule misses warnings for inherited public static bounds and fully qualified ValidateRange declarations without the Attribute suffix because its reflection lookups do not support either case.

2 open issues

• Include inherited public static fields in bounds lookup · New
• Resolve ValidateRange attributes with optional Attribute suffix · New

What changed in this PR

This PR refines AvoidValidateRangeTypeMismatch to recognize static integral constants without invoking property getters and to identify the actual PowerShell validation attribute.

Changes:

• Detect public static integral constant fields used as range bounds.
• Replace attribute-name matching with a resolved-type comparison.
• Add regression cases for [int]::MaxValue and an unrelated attribute name.

File	Description
Tests/​Rules/​AvoidValidateRangeTypeMismatch.tests.ps1	Adds constant-bound and unrelated-attribute regression cases.
Rules/​AvoidValidateRangeTypeMismatch.cs	Adds constant-field detection and exact attribute-type matching.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The negative test never loads Contoso.ValidateRangeAttribute, leaving rejection of a successfully resolved custom attribute untested.

1 open issue

• Add ValidateRangeAttribute fixture to test resolved custom attributes · New

2 resolved since last review

• Resolve ValidateRange attributes with optional Attribute suffix
• Include inherited public static fields in bounds lookup

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The member-expression tests lack negative coverage for throwing static getters, static readonly integral fields, and floating-point constants, leaving getter non-execution and literal-integral-only behavior unguarded against regressions.

2 open issues

• The new member-expression path is tested only with integral constants. Please also add negative… · New
• Add ValidateRangeAttribute fixture to test resolved custom attributes

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are reported for the added static integral constant support and stricter attribute matching.

2 open issues

• The new member-expression path is tested only with integral constants. Please also add negative…
• Add ValidateRangeAttribute fixture to test resolved custom attributes

_{Review effort: Balanced}

[Christoph Bergmeister (bergmeister)]

🟢 Approval recommended

No active review issues are reported for the added static integral constant support and stricter attribute matching.

2 open issues

• The new member-expression path is tested only with integral constants. Please also add negative…
• Add ValidateRangeAttribute fixture to test resolved custom attributes

Review effort: Balanced

Copilot fix the 2 open issues

[Copilot]

🟢 Approval recommended

No active review issues are reported for the added static integral constant support and stricter attribute matching.

...

Both open items are already addressed on this branch: the resolved Contoso.ValidateRangeAttribute fixture is in 0fd8633, and the throwing-getter, readonly-integral, and floating-point negative cases are in bd60450. CI passed on the current commit.

[Copilot]

🟢 Approval recommended

No active review issues were identified for the changes supporting static integral bounds and excluding unrelated custom attributes.

No open issues 🎉

2 resolved since last review

• The new member-expression path is tested only with integral constants. Please also add negative…
• Add ValidateRangeAttribute fixture to test resolved custom attributes

_{Review effort: Balanced}